Skip to content

docs: remove obsolete problem post-install hook #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2024

Conversation

MikeMcC399
Copy link
Collaborator

Issue

README > Common problems > Cannot run post-install hook recommends using npm install --unsafe-perm.

Background

Currently the minimum supported version of Node.js is 18.x. The note relates to npm rather than Node.js itself. npm is bundled in Node.js.

The lowest Node.js 18.x version is Node.js 18.0.0 which bundles npm 8.6.0.

The npm CHANGELOG 7.0.0 > All Lifecycle Scripts says:

The user, group, uid, gid, and unsafe-perms configurations are no longer relevant. When npm is run as root, scripts are always run with the effective uid and gid of the working directory owner.

The lowest version of npm currently supported is 8.6.0 (see above). The conclusion is that the problem no longer applies to any currently supported version of npm and therefore the problem description is obsolete.

Change

Remove the obsolete section README > Common problems > Cannot run post-install hook.

@MikeMcC399

This comment was marked as outdated.

@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 self-assigned this May 30, 2024
@MikeMcC399 MikeMcC399 marked this pull request as ready for review May 30, 2024 10:14
@MikeMcC399 MikeMcC399 force-pushed the remove/unsafe-perm branch from 441f015 to 9fc6b3c Compare May 30, 2024 13:39
@MikeMcC399

This comment was marked as outdated.

@MikeMcC399 MikeMcC399 force-pushed the remove/unsafe-perm branch from 9fc6b3c to fa78eaa Compare May 30, 2024 13:47
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@jennifer-shehane jennifer-shehane merged commit 7a5042b into cypress-io:master May 31, 2024
31 checks passed
@MikeMcC399 MikeMcC399 deleted the remove/unsafe-perm branch May 31, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants